natas_hw
/
cassandra
mirror of https://github.com/apache/cassandra
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not make DNS lookup when querying system_views.clients for hostname column by removing it 

By removing hostname column we are on par with nodetool clientstats

patch by Nivy Kani; reviewed by Stefan Miklosovic, Brandon Williams for CASSANDRA-21539
This commit is contained in:
nivy 2026-07-31 15:28:00 -07:00 committed by Stefan Miklosovic
parent c6da57e12e
commit 658c79182d
No known key found for this signature in database
GPG Key ID: 32F35CB2F546D93E
3 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES.txt
View File

@ -1,4 +1,5 @@
4.0.22
* Do not make DNS lookup when querying system_views.clients for hostname column by removing it (CASSANDRA-21539)
* Fix memtable on-heap accounting drift in BTree.update and BTreeRow.merge (CASSANDRA-21472)

19
doc/modules/cassandra/pages/new/virtualtables.adoc
View File

@ -107,15 +107,15 @@ We shall discuss some of the virtual tables in more detail next.
The `clients` virtual table lists all active connections (connected
clients) including their ip address, port, connection stage, driver
name, driver version, hostname, protocol version, request count, ssl
name, driver version, protocol version, request count, ssl
enabled, ssl protocol and user name:
....
cqlsh:system_views> select * from system_views.clients;
address | port | connection_stage | driver_name | driver_version | hostname | protocol_version | request_count | ssl_cipher_suite | ssl_enabled | ssl_protocol | username
-----------+-------+------------------+-------------+----------------+-----------+------------------+---------------+------------------+-------------+--------------+-----------
127.0.0.1 | 50628 | ready | null | null | localhost | 4 | 55 | null | False | null | anonymous
127.0.0.1 | 50630 | ready | null | null | localhost | 4 | 70 | null | False | null | anonymous
address | port | connection_stage | driver_name | driver_version | protocol_version | request_count | ssl_cipher_suite | ssl_enabled | ssl_protocol | username
-----------+-------+------------------+-------------+----------------+------------------+---------------+------------------+-------------+--------------+-----------
127.0.0.1 | 50628 | ready | null | null | 4 | 55 | null | False | null | anonymous
127.0.0.1 | 50630 | ready | null | null | 4 | 70 | null | False | null | anonymous
(2 rows)
....
@ -139,7 +139,6 @@ CREATE TABLE system_views.clients (
connection_stage text,
driver_name text,
driver_version text,
hostname text,
port int,
protocol_version int,
request_count bigint,
@ -401,10 +400,10 @@ cqlsh> SELECT * FROM clients LIMIT 2;
[source, cql]
----
address | port | connection_stage | driver_name | driver_version | hostname | protocol_version | request_count | ssl_cipher_suite | ssl_enabled | ssl_protocol | username
-----------+-------+------------------+------------------------+----------------+-----------+------------------+---------------+------------------+-------------+--------------+-----------
127.0.0.1 | 37308 | ready | DataStax Python Driver | 3.21.0.post0 | localhost | 4 | 17 | null | False | null | anonymous
127.0.0.1 | 37310 | ready | DataStax Python Driver | 3.21.0.post0 | localhost | 4 | 8 | null | False | null | anonymous
address | port | connection_stage | driver_name | driver_version | protocol_version | request_count | ssl_cipher_suite | ssl_enabled | ssl_protocol | username
-----------+-------+------------------+------------------------+----------------+------------------+---------------+------------------+-------------+--------------+-----------
127.0.0.1 | 37308 | ready | DataStax Python Driver | 3.21.0.post0 | 4 | 17 | null | False | null | anonymous
127.0.0.1 | 37310 | ready | DataStax Python Driver | 3.21.0.post0 | 4 | 8 | null | False | null | anonymous
(2 rows)
----

3
src/java/org/apache/cassandra/db/virtual/ClientsTable.java
View File

@ -29,7 +29,6 @@ final class ClientsTable extends AbstractVirtualTable
{
private static final String ADDRESS = "address";
private static final String PORT = "port";
private static final String HOSTNAME = "hostname";
private static final String USERNAME = "username";
private static final String CONNECTION_STAGE = "connection_stage";
private static final String PROTOCOL_VERSION = "protocol_version";
@ -48,7 +47,6 @@ final class ClientsTable extends AbstractVirtualTable
.partitioner(new LocalPartitioner(InetAddressType.instance))
.addPartitionKeyColumn(ADDRESS, InetAddressType.instance)
.addClusteringColumn(PORT, Int32Type.instance)
.addRegularColumn(HOSTNAME, UTF8Type.instance)
.addRegularColumn(USERNAME, UTF8Type.instance)
.addRegularColumn(CONNECTION_STAGE, UTF8Type.instance)
.addRegularColumn(PROTOCOL_VERSION, Int32Type.instance)
@ -71,7 +69,6 @@ final class ClientsTable extends AbstractVirtualTable
InetSocketAddress remoteAddress = client.remoteAddress();
result.row(remoteAddress.getAddress(), remoteAddress.getPort())
.column(HOSTNAME, remoteAddress.getHostName())
.column(USERNAME, client.username().orElse(null))
.column(CONNECTION_STAGE, client.stage().toString().toLowerCase())
.column(PROTOCOL_VERSION, client.protocolVersion())