From 88dbf121e3190d215780f2f01565e26874195d84 Mon Sep 17 00:00:00 2001
From: tomer-mobb <132216976+tomer-mobb@users.noreply.github.com>
Date: Mon, 15 Jan 2024 23:15:13 +0700
Subject: [PATCH] Path Traversal fix in SSTableRepairedAtSetter.java

A Path Traversal issue reported by Snyk security scanner has been fixed by Mobb Automatic Fixer.
---
 .../tools/SSTableRepairedAtSetter.java        | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/src/java/org/apache/cassandra/tools/SSTableRepairedAtSetter.java b/src/java/org/apache/cassandra/tools/SSTableRepairedAtSetter.java
index f5ee3df650..b5b6e79609 100644
--- a/src/java/org/apache/cassandra/tools/SSTableRepairedAtSetter.java
+++ b/src/java/org/apache/cassandra/tools/SSTableRepairedAtSetter.java
@@ -29,6 +29,8 @@ import java.util.List;
 import org.apache.cassandra.io.sstable.Descriptor;
 import org.apache.cassandra.io.sstable.format.SSTableFormat.Components;
 import org.apache.cassandra.io.util.File;
+import java.io.File;
+import java.net.URI;
 
 public class SSTableRepairedAtSetter
 {
@@ -69,6 +71,8 @@ public class SSTableRepairedAtSetter
 
         for (String fname: fileNames)
         {
+            // Path Traversal issue fixed by Mobb:
+            ensurePathIsRelative(fname);
             Descriptor descriptor = Descriptor.fromFileWithComponent(new File(fname), false).left;
             if (!descriptor.version.isCompatible())
             {
@@ -87,4 +91,31 @@ public class SSTableRepairedAtSetter
             }
         }
     }
+    
+    private static void ensurePathIsRelative(String path) {
+         ensurePathIsRelative(new File(path));
+    }
+    private static void ensurePathIsRelative(URI uri) {
+         ensurePathIsRelative(new File(uri));
+    }
+    private static void ensurePathIsRelative(File file) {
+         // Based on https://stackoverflow.com/questions/2375903/whats-the-best-way-to-defend-against-a-path-traversal-attack/34658355#34658355
+         String canonicalPath;
+         String absolutePath;
+    
+         if (file.isAbsolute()) {
+              throw new RuntimeException("Potential directory traversal attempt - absolute path not allowed");
+         }
+    
+         try {
+              canonicalPath = file.getCanonicalPath();
+              absolutePath = file.getAbsolutePath();
+         } catch (IOException e) {
+              throw new RuntimeException("Potential directory traversal attempt", e);
+         }
+    
+         if (!canonicalPath.startsWith(absolutePath) || !canonicalPath.equals(absolutePath)) {
+              throw new RuntimeException("Potential directory traversal attempt");
+         }
+    }
 }