From 4885bfccf1841def0c86b46302133cf2924d7acd Mon Sep 17 00:00:00 2001
From: Sylvain Lebresne <sylvain@datastax.com>
Date: Fri, 14 Dec 2012 16:52:29 +0100
Subject: [PATCH] Fix compression options validation

patch by slebresne; reviewed by iamaleksey for CASSANDRA-5066
---
 CHANGES.txt                                                   | 2 +-
 .../apache/cassandra/io/compress/CompressionParameters.java   | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/CHANGES.txt b/CHANGES.txt
index c9f1098bd7..03b62c8d8e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -7,7 +7,7 @@
  * Fall back to old describe_splits if d_s_ex is not available (CASSANDRA-4803)
  * Improve error reporting when streaming ranges fail (CASSANDRA-5009)
  * cqlsh: fix timestamp formatting on some platforms (CASSANDRA-5046)
- * Fix ALTER TABLE overriding compression options with defaults (CASSANDRA-4996)
+ * Fix ALTER TABLE overriding compression options with defaults (CASSANDRA-4996, 5066)
  * Avoid error opening data file on startup (CASSANDRA-4984)
  * Fix wrong index_options in cli 'show schema' (CASSANDRA-5008)
  * Allow overriding number of available processor (CASSANDRA-4790)
diff --git a/src/java/org/apache/cassandra/io/compress/CompressionParameters.java b/src/java/org/apache/cassandra/io/compress/CompressionParameters.java
index c8a15d70c7..9be71f62fd 100644
--- a/src/java/org/apache/cassandra/io/compress/CompressionParameters.java
+++ b/src/java/org/apache/cassandra/io/compress/CompressionParameters.java
@@ -100,7 +100,11 @@ public class CompressionParameters
     private static ICompressor createCompressor(Class<? extends ICompressor> compressorClass, Map<String, String> compressionOptions) throws ConfigurationException
     {
         if (compressorClass == null)
+        {
+            if (!compressionOptions.isEmpty())
+                throw new ConfigurationException("Unknown compression options (" + compressionOptions.keySet() + ") since no compression class found");
             return null;
+        }
 
         try
         {