natas_hw
/
cassandra
mirror of https://github.com/apache/cassandra
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Verify the audit logger class without initializing it during the existence check 

isAuditLoggerClassExists loaded the configured audit logger class through the initializing helper only
to test for its presence. Load it without initialization and verify it is an IAuditLogger instead.
This commit is contained in:
Jeremiah Jordan 2026-07-17 11:18:07 -05:00
parent ea302e2294
commit 2a38e03070
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/java/org/apache/cassandra/utils/FBUtilities.java
View File

@ -695,7 +695,7 @@ public class FBUtilities
try
{
FBUtilities.classForName(className, "Audit logger");
FBUtilities.classForNameWithoutInitialization(className, "Audit logger", IAuditLogger.class);
}
catch (ConfigurationException e)
{

12
test/unit/org/apache/cassandra/utils/FBUtilitiesTest.java
View File

@ -52,6 +52,7 @@ import org.apache.cassandra.exceptions.ConfigurationException;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
public class FBUtilitiesTest
@ -101,6 +102,17 @@ public class FBUtilitiesTest
assertFalse(ClassLoadingTestSupport.wasInitialized(ClassLoadingTestNonAssignable.class));
}
@Test
public void testIsAuditLoggerClassExistsRejectsWrongTypeWithoutInitializing()
{
ClassLoadingTestSupport.assertNotInitialized(ClassLoadingTestNonAssignable.class);
assertFalse(FBUtilities.isAuditLoggerClassExists(ClassLoadingTestNonAssignable.class.getName()));
assertFalse(ClassLoadingTestSupport.wasInitialized(ClassLoadingTestNonAssignable.class));
assertTrue(FBUtilities.isAuditLoggerClassExists("NoOpAuditLogger"));
assertFalse(FBUtilities.isAuditLoggerClassExists("does.not.ExistAuditLogger"));
}
@Test
public void testCompareByteSubArrays()
{