From 175e4f8ce868ea04a5e11a8d5212d8c397ea0d12 Mon Sep 17 00:00:00 2001 From: adelapena Date: Thu, 20 Apr 2017 13:16:15 +0100 Subject: [PATCH] Fix SSTableLoader fail when the loaded table contains dropped columns (CASSANDRA-13276) --- CHANGES.txt | 1 + .../utils/NativeSSTableLoaderClient.java | 43 ++++++++++++++----- 2 files changed, 34 insertions(+), 10 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 81d5b06a94..6a1e48660a 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.0.14 + * Fix SSTableLoader fail when the loaded table contains dropped columns (CASSANDRA-13276) * Avoid name clashes in CassandraIndexTest (CASSANDRA-13427) * Handling partially written hint files (CASSANDRA-12728) * Interrupt replaying hints on decommission (CASSANDRA-13308) diff --git a/src/java/org/apache/cassandra/utils/NativeSSTableLoaderClient.java b/src/java/org/apache/cassandra/utils/NativeSSTableLoaderClient.java index 4c6b12e8a9..97237d0189 100644 --- a/src/java/org/apache/cassandra/utils/NativeSSTableLoaderClient.java +++ b/src/java/org/apache/cassandra/utils/NativeSSTableLoaderClient.java @@ -18,7 +18,9 @@ package org.apache.cassandra.utils; import java.net.InetAddress; +import java.nio.ByteBuffer; import java.util.*; +import java.util.concurrent.TimeUnit; import com.datastax.driver.core.*; @@ -184,16 +186,29 @@ public class NativeSSTableLoaderClient extends SSTableLoader.Client for (Row colRow : session.execute(columnsQuery, keyspace, name)) defs.add(createDefinitionFromRow(colRow, keyspace, name, types)); - return CFMetaData.create(keyspace, - name, - id, - isDense, - isCompound, - isSuper, - isCounter, - isView, - defs, - partitioner); + CFMetaData metadata = CFMetaData.create(keyspace, + name, + id, + isDense, + isCompound, + isSuper, + isCounter, + isView, + defs, + partitioner); + + String droppedColumnsQuery = String.format("SELECT * FROM %s.%s WHERE keyspace_name = ? AND table_name = ?", + SchemaKeyspace.NAME, + SchemaKeyspace.DROPPED_COLUMNS); + Map droppedColumns = new HashMap<>(); + for (Row colRow : session.execute(droppedColumnsQuery, keyspace, name)) + { + CFMetaData.DroppedColumn droppedColumn = createDroppedColumnFromRow(colRow, keyspace); + droppedColumns.put(UTF8Type.instance.decompose(droppedColumn.name), droppedColumn); + } + metadata.droppedColumns(droppedColumns); + + return metadata; } private static ColumnDefinition createDefinitionFromRow(Row row, String keyspace, String table, Types types) @@ -211,4 +226,12 @@ public class NativeSSTableLoaderClient extends SSTableLoader.Client ColumnDefinition.Kind kind = ColumnDefinition.Kind.valueOf(row.getString("kind").toUpperCase()); return new ColumnDefinition(keyspace, table, name, type, position, kind); } + + private static CFMetaData.DroppedColumn createDroppedColumnFromRow(Row row, String keyspace) + { + String name = row.getString("column_name"); + AbstractType type = CQLTypeParser.parse(keyspace, row.getString("type"), Types.none()); + long droppedTime = TimeUnit.MILLISECONDS.toMicros(row.getTimestamp("dropped_time").getTime()); + return new CFMetaData.DroppedColumn(name, type, droppedTime); + } }