diff --git a/build.xml b/build.xml index 1f14e057..45298998 100644 --- a/build.xml +++ b/build.xml @@ -49,13 +49,13 @@ - - @@ -262,7 +262,7 @@ todir="${ant.classes.build.dir}/fr/jayasoft/ivy/ant"/> - + + + + + @@ -550,7 +555,7 @@ - + diff --git a/src/java/org/apache/ivy/plugins/lock/DeleteOnExitHook.java b/src/java/org/apache/ivy/plugins/lock/DeleteOnExitHook.java index bb86970a..ea3fe40b 100644 --- a/src/java/org/apache/ivy/plugins/lock/DeleteOnExitHook.java +++ b/src/java/org/apache/ivy/plugins/lock/DeleteOnExitHook.java @@ -21,7 +21,7 @@ import java.io.File; import java.util.Iterator; import java.util.LinkedHashSet; -class DeleteOnExitHook { +final class DeleteOnExitHook { static { Runtime.getRuntime().addShutdownHook(new Thread() { diff --git a/src/java/org/apache/ivy/util/DateUtil.java b/src/java/org/apache/ivy/util/DateUtil.java index fe66e1d9..1190b6ba 100644 --- a/src/java/org/apache/ivy/util/DateUtil.java +++ b/src/java/org/apache/ivy/util/DateUtil.java @@ -21,7 +21,7 @@ import java.text.ParseException; import java.text.SimpleDateFormat; import java.util.Date; -public class DateUtil { +public final class DateUtil { private DateUtil() { // Utility class diff --git a/src/java/org/apache/ivy/util/EncryptedProperties.java b/src/java/org/apache/ivy/util/EncryptedProperties.java index cbed9520..26443729 100644 --- a/src/java/org/apache/ivy/util/EncryptedProperties.java +++ b/src/java/org/apache/ivy/util/EncryptedProperties.java @@ -29,6 +29,7 @@ import java.util.Properties; * putAll puts given values without encrypting them. It this thus recommended to void using them, * use setProperty and getProperty instead. */ +@SuppressWarnings("serial") public class EncryptedProperties extends Properties { public EncryptedProperties() { diff --git a/src/java/org/apache/ivy/util/EncrytedProperties.java b/src/java/org/apache/ivy/util/EncrytedProperties.java index 3242de52..a2a998d5 100644 --- a/src/java/org/apache/ivy/util/EncrytedProperties.java +++ b/src/java/org/apache/ivy/util/EncrytedProperties.java @@ -17,10 +17,10 @@ */ package org.apache.ivy.util; - /** * Deprecated because of renaming due spell check. */ +@SuppressWarnings("serial") @Deprecated public class EncrytedProperties extends EncryptedProperties { } \ No newline at end of file diff --git a/test/java/org/apache/ivy/core/TestPerformance.java b/test/java/org/apache/ivy/core/TestPerformance.java index 29a91763..64ea1dfc 100644 --- a/test/java/org/apache/ivy/core/TestPerformance.java +++ b/test/java/org/apache/ivy/core/TestPerformance.java @@ -140,11 +140,4 @@ public class TestPerformance { private ResolveOptions getResolveOptions(String[] confs) { return new ResolveOptions().setConfs(confs); } - - public static void main(String[] args) throws Exception { - TestPerformance t = new TestPerformance(); - t.setUp(); - t.testPerfs(); - t.tearDown(); - } } diff --git a/test/java/org/apache/ivy/core/module/descriptor/DefaultDependencyDescriptorTest.java b/test/java/org/apache/ivy/core/module/descriptor/DefaultDependencyDescriptorTest.java index d89813d1..099d9968 100644 --- a/test/java/org/apache/ivy/core/module/descriptor/DefaultDependencyDescriptorTest.java +++ b/test/java/org/apache/ivy/core/module/descriptor/DefaultDependencyDescriptorTest.java @@ -19,17 +19,12 @@ package org.apache.ivy.core.module.descriptor; import org.junit.Test; -import org.junit.runner.JUnitCore; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNull; public class DefaultDependencyDescriptorTest { - public static void main(String[] args) { - JUnitCore.runClasses(DefaultDependencyDescriptorTest.class); - } - /* * Test method for * 'org.apache.ivy.DefaultDependencyDescriptor.replaceSelfFallbackPattern(String, String)' diff --git a/test/java/org/apache/ivy/core/settings/XmlSettingsParserTest.java b/test/java/org/apache/ivy/core/settings/XmlSettingsParserTest.java index 6bbd8853..e3db0424 100644 --- a/test/java/org/apache/ivy/core/settings/XmlSettingsParserTest.java +++ b/test/java/org/apache/ivy/core/settings/XmlSettingsParserTest.java @@ -17,13 +17,17 @@ */ package org.apache.ivy.core.settings; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; + import java.io.File; import java.io.IOException; import java.text.ParseException; import java.util.List; import org.apache.ivy.core.cache.DefaultRepositoryCacheManager; -import org.apache.ivy.core.cache.RepositoryCacheManager; import org.apache.ivy.core.cache.ResolutionCacheManager; import org.apache.ivy.core.module.descriptor.Artifact; import org.apache.ivy.core.module.id.ModuleId; @@ -47,13 +51,10 @@ import org.apache.ivy.plugins.resolver.packager.PackagerResolver; import org.apache.ivy.plugins.version.ChainVersionMatcher; import org.apache.ivy.plugins.version.MockVersionMatcher; import org.apache.ivy.plugins.version.VersionMatcher; - import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; -import static org.junit.Assert.*; - /** * TODO write javadoc */