From 463a2c89c3840c35ceadd786a6b1781e0e8fd5a3 Mon Sep 17 00:00:00 2001
From: Gintas Grigelionis
* Please use {@link #getURLInfo(URL, TimeoutConstraint)} if more one information about the
* Please use {@link #getURLInfo(URL, TimeoutConstraint)} if more one information about the
* Example of use:
- *
+ *
* Examples:
- *
+ * url
* is needed
+ * url
* is needed
+ *
+ * modules, using micro ivy format to describe the repository.
+ *
* public class MyTest {
* private TestFixture fixture;
*
- * @Before
+ * @Before
* public void setUp() throws Exception {
* fixture = new TestFixture();
* // additional setup here
* }
*
- * @After
+ * @After
* public void tearDown() throws Exception {
* fixture.clean();
* }
*
- * @Test
+ * @Test
* public void testXXX() throws Exception {
* fixture.addMD("#A;1-> { #B;[1.5,1.6] #C;2.5 }").addMD("#B;1.5->#D;2.0")
* .addMD("#B;1.6->#D;2.0").addMD("#C;2.5->#D;[1.0,1.6]").addMD("#D;1.5")
diff --git a/test/java/org/apache/ivy/TestHelper.java b/test/java/org/apache/ivy/TestHelper.java
index e206d3b4..57303bd9 100644
--- a/test/java/org/apache/ivy/TestHelper.java
+++ b/test/java/org/apache/ivy/TestHelper.java
@@ -43,7 +43,6 @@ import org.apache.tools.ant.DefaultLogger;
import org.apache.tools.ant.Project;
import org.apache.tools.ant.taskdefs.Delete;
-
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
@@ -144,25 +143,19 @@ public class TestHelper {
* Parses a string representation of a module descriptor in micro ivy format.
*
* #A;1
*
- *
- *
- *
+ *
*
- * #A;2-> #B;[1.0,1.5]
+ * #A;2-> #B;[1.0,1.5]
*
- *
- *
- *
+ *
*
- * #A;3-> { #B;[1.0,1.5] #C;[2.0,2.5] }
+ * #A;3-> { #B;[1.0,1.5] #C;[2.0,2.5] }
*
*
- *
includes another file as optional,
* then the absence of that file doesn't lead to failures
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testOptionalFileInclude() throws Exception {
diff --git a/test/java/org/apache/ivy/ant/IvyDeliverTest.java b/test/java/org/apache/ivy/ant/IvyDeliverTest.java
index 5bcc689e..056e9e7c 100644
--- a/test/java/org/apache/ivy/ant/IvyDeliverTest.java
+++ b/test/java/org/apache/ivy/ant/IvyDeliverTest.java
@@ -297,9 +297,14 @@ public class IvyDeliverTest {
md.getModuleRevisionId());
}
+ /**
+ * Test case for IVY-404.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-404
+ */
@Test
public void testWithBranch() throws Exception {
- // test case for IVY-404
project.setProperty("ivy.dep.file", "test/java/org/apache/ivy/ant/ivy-latest-branch.xml");
IvyResolve res = new IvyResolve();
res.setProject(project);
@@ -358,9 +363,14 @@ public class IvyDeliverTest {
dds[0].getDynamicConstraintDependencyRevisionId());
}
+ /**
+ * Test case for IVY-415.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-415
+ */
@Test
public void testWithExtraAttributes() throws Exception {
- // test case for IVY-415
project.setProperty("ivy.dep.file", "test/java/org/apache/ivy/ant/ivy-latest-extra.xml");
IvyResolve res = new IvyResolve();
res.setValidate(false);
@@ -432,10 +442,15 @@ public class IvyDeliverTest {
expectedFileSet, actualFileSet);
}
+ /**
+ * Test case for IVY-707.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-707
+ */
@Test
public void testWithDynEvicted2() throws Exception {
// same as previous but dynamic dependency is placed after the one causing the conflict
- // test case for IVY-707
project.setProperty("ivy.dep.file", "test/java/org/apache/ivy/ant/ivy-dyn-evicted2.xml");
IvyResolve res = new IvyResolve();
res.setValidate(false);
diff --git a/test/java/org/apache/ivy/ant/IvyDependencyTreeTest.java b/test/java/org/apache/ivy/ant/IvyDependencyTreeTest.java
index bf41b276..633f0a37 100644
--- a/test/java/org/apache/ivy/ant/IvyDependencyTreeTest.java
+++ b/test/java/org/apache/ivy/ant/IvyDependencyTreeTest.java
@@ -87,7 +87,7 @@ public class IvyDependencyTreeTest extends AntTaskTestCase {
/**
* Task must fail because no resolve was performed.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testWithResolveIdWithoutResolve() throws Exception {
@@ -118,10 +118,11 @@ public class IvyDependencyTreeTest extends AntTaskTestCase {
}
/**
- * Tests that dependency tree task doesn't run into an infinite loop due to circular dependencies
+ * Test case for IVY-1540.
+ * Dependency tree task must not run into an infinite loop due to circular dependencies.
*
- * @throws Exception
- * @see IVY-1540 for more details
+ * @throws Exception if something goes wrong
+ * @see IVY-1540
*/
@Test
public void testCircularDep() throws Exception {
diff --git a/test/java/org/apache/ivy/ant/IvyDependencyUpdateCheckerTest.java b/test/java/org/apache/ivy/ant/IvyDependencyUpdateCheckerTest.java
index ed8c4ab7..9501a1b8 100644
--- a/test/java/org/apache/ivy/ant/IvyDependencyUpdateCheckerTest.java
+++ b/test/java/org/apache/ivy/ant/IvyDependencyUpdateCheckerTest.java
@@ -120,7 +120,7 @@ public class IvyDependencyUpdateCheckerTest extends AntTaskTestCase {
/**
* Test must fail with default haltonfailure setting.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testInlineForNonExistingModule() throws Exception {
@@ -135,7 +135,7 @@ public class IvyDependencyUpdateCheckerTest extends AntTaskTestCase {
/**
* Test must fail with default haltonfailure setting.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testFailure() throws Exception {
@@ -147,7 +147,7 @@ public class IvyDependencyUpdateCheckerTest extends AntTaskTestCase {
/**
* Test must fail because of missing configurations.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testFailureWithMissingConfigurations() throws Exception {
@@ -163,7 +163,7 @@ public class IvyDependencyUpdateCheckerTest extends AntTaskTestCase {
/**
* Test must fail with default haltonfailure setting.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testFailureOnBadDependencyIvyFile() throws Exception {
@@ -175,7 +175,7 @@ public class IvyDependencyUpdateCheckerTest extends AntTaskTestCase {
/**
* Test must fail with default haltonfailure setting.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testFailureOnBadStatusInDependencyIvyFile() throws Exception {
@@ -215,9 +215,13 @@ public class IvyDependencyUpdateCheckerTest extends AntTaskTestCase {
assertFalse(project.getProperty("ivy.resolved.configurations").contains("default"));
}
+ /**
+ * Test case for IVY-396.
+ *
+ * @see IVY-396
+ */
@Test
public void testResolveWithAbsoluteFile() {
- // IVY-396
File ivyFile = new File("test/java/org/apache/ivy/ant/ivy-simple.xml");
dependencyUpdateChecker.getProject().setProperty("ivy.dep.file", ivyFile.getAbsolutePath());
dependencyUpdateChecker.execute();
@@ -226,9 +230,13 @@ public class IvyDependencyUpdateCheckerTest extends AntTaskTestCase {
// ModuleRevisionId.newInstance("apache", "resolve-simple", "1.0")).exists());
}
+ /**
+ * Test case for IVY-396.
+ *
+ * @see IVY-396
+ */
@Test
public void testResolveWithRelativeFile() {
- // IVY-396
dependencyUpdateChecker.getProject().setProperty("ivy.dep.file",
"test/java/org/apache/ivy/ant/ivy-simple.xml");
dependencyUpdateChecker.execute();
diff --git a/test/java/org/apache/ivy/ant/IvyInfoTest.java b/test/java/org/apache/ivy/ant/IvyInfoTest.java
index 3930a9db..5d52a22f 100644
--- a/test/java/org/apache/ivy/ant/IvyInfoTest.java
+++ b/test/java/org/apache/ivy/ant/IvyInfoTest.java
@@ -75,6 +75,12 @@ public class IvyInfoTest {
assertNull(info.getProject().getProperty("ivy.configuration.private.desc"));
}
+ /**
+ * Test case for IVY-726.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-726
+ */
@Test
public void testIVY726() throws Exception {
info.setFile(new File("test/java/org/apache/ivy/ant/ivy-info-all.xml"));
@@ -83,6 +89,12 @@ public class IvyInfoTest {
assertTrue(info.getProject().getProperty("ivy.extra.branch") == null);
}
+ /**
+ * Test case for IVY-395.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-395
+ */
@Test
public void testIVY395() throws Exception {
info.setFile(new File("test/java/org/apache/ivy/ant/ivy-artifact-info.xml"));
diff --git a/test/java/org/apache/ivy/ant/IvyInstallTest.java b/test/java/org/apache/ivy/ant/IvyInstallTest.java
index 1f24f7a9..69c7873e 100644
--- a/test/java/org/apache/ivy/ant/IvyInstallTest.java
+++ b/test/java/org/apache/ivy/ant/IvyInstallTest.java
@@ -127,7 +127,7 @@ public class IvyInstallTest {
}
/**
- * Normal case; no confs set (should use the default->* configuration).
+ * Normal case; no confs set (should use the default->* configuration).
*/
@Test
public void testInstallWithConfsDefaultSettings() {
@@ -147,7 +147,10 @@ public class IvyInstallTest {
}
/**
- * Test retrieving artifacts under only the master and runtime configuration.
+ * Test case for IVY-1313.
+ * Retrieve artifacts only for the master and runtime configuration.
+ *
+ * @see IVY-1313
*/
@Test
public void testInstallWithConfsRuntimeOnly() {
@@ -167,9 +170,14 @@ public class IvyInstallTest {
assertFalse(new File("build/test/install/org1/mod3/jars/mod3-1.0.jar").exists());
}
+ /**
+ * Test case for IVY-1324.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-1324
+ */
@Test
public void testInstallWithClassifiers() throws Exception {
- // IVY-1324
project.setProperty("ivy.settings.url", new File("test/repositories/m2/ivysettings.xml")
.toURI().toURL().toExternalForm());
install.setOrganisation("org.apache");
@@ -236,6 +244,11 @@ public class IvyInstallTest {
assertTrue(new File("build/test/install/org.apache/test/test-1.0.pom").exists());
}
+ /**
+ * Test case for IVY-843.
+ *
+ * @see IVY-843
+ */
@Test
public void testIVY843() {
project.setProperty("ivy.settings.file", "test/repositories/ivysettings-IVY843.xml");
@@ -288,9 +301,9 @@ public class IvyInstallTest {
}
/**
- * Installing a module with namespace coordinates instead of system one should fail.
+ * Installing a module with namespace coordinates instead of system one must fail.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testInstallWithNamespace2() throws Exception {
@@ -323,7 +336,7 @@ public class IvyInstallTest {
/**
* Fail on unknown dependency when haltonfailure=true.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testDependencyNotFoundFailure() throws Exception {
diff --git a/test/java/org/apache/ivy/ant/IvyPublishTest.java b/test/java/org/apache/ivy/ant/IvyPublishTest.java
index e20c0ad3..4109c2c1 100644
--- a/test/java/org/apache/ivy/ant/IvyPublishTest.java
+++ b/test/java/org/apache/ivy/ant/IvyPublishTest.java
@@ -160,12 +160,17 @@ public class IvyPublishTest {
}
}
+ /**
+ * Test case for IVY-1248.
+ *
+ * @throws IOException if something goes wrong
+ * @throws ParseException if something goes wrong
+ * @see IVY-1248
+ */
@Test
public void testMergeParentWithoutPublishingParent() throws IOException, ParseException {
// here we directly publish a module extending ivy-multiconf.xml,
// the module parent is not published not yet in cache
- // See : IVY-1248
-
// update=true implies merge=true
// project.setProperty("ivy.dep.file",
// "test/java/org/apache/ivy/ant/ivy-extends-multiconf.xml");
@@ -185,13 +190,18 @@ public class IvyPublishTest {
checkPublishedFile(published, "ivy-extends-merged.xml");
}
+ /**
+ * Test case for IVY-1248.
+ * Here we directly publish a module extending ivy-multiconf.xml,
+ * the module parent is not published not yet in cache.
+ *
+ * @throws IOException if something goes wrong
+ * @throws ParseException if something goes wrong
+ * @see IVY-1248
+ */
@Test
public void testMergeParentWithoutPublishingParentForceDeliver()
throws IOException, ParseException {
- // here we directly publish a module extending ivy-multiconf.xml,
- // the module parent is not published not yet in cache
- // See : IVY-1248
-
IvyResolve resolve = new IvyResolve();
resolve.setProject(project);
resolve.setFile(new File("test/java/org/apache/ivy/ant/ivy-extends-multiconf.xml"));
@@ -218,8 +228,6 @@ public class IvyPublishTest {
@Test
public void testMergeParentWithoutLocationAttribute() throws IOException, ParseException {
- // See : IVY-XXX
-
IvyResolve resolve = new IvyResolve();
resolve.setProject(project);
resolve.setFile(new File("test/java/org/apache/ivy/ant/extends/child1/ivy-child1.xml"));
@@ -711,7 +719,7 @@ public class IvyPublishTest {
/**
* Test must not publish ivy file with bad revision.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testBadNoDeliver() throws Exception {
diff --git a/test/java/org/apache/ivy/ant/IvyResolveTest.java b/test/java/org/apache/ivy/ant/IvyResolveTest.java
index ee220e9f..3e2ebb2d 100644
--- a/test/java/org/apache/ivy/ant/IvyResolveTest.java
+++ b/test/java/org/apache/ivy/ant/IvyResolveTest.java
@@ -62,6 +62,12 @@ public class IvyResolveTest {
TestHelper.cleanCache();
}
+ /**
+ * Test case for IVY-1455.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-1455
+ */
@Test
public void testIVY1455() throws Exception {
project.setProperty("ivy.settings.file", "test/repositories/IVY-1455/ivysettings.xml");
@@ -87,6 +93,12 @@ public class IvyResolveTest {
parallel.execute();
}
+ /**
+ * Test case for IVY-779.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-779
+ */
@Test
public void testIVY779() throws Exception {
Project project = TestHelper.newProject();
@@ -122,9 +134,14 @@ public class IvyResolveTest {
assertTrue(getArchiveFileInCache("org1", "mod1.2", "2.0", "mod1.2", "jar", "jar").exists());
}
+ /**
+ * Test case for IVY-630.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-630
+ */
@Test
public void testResolveWithoutIvyFile() throws Exception {
- // IVY-630
resolve.getProject().setProperty("ivy.settings.file",
"test/repositories/IVY-630/ivysettings.xml");
@@ -444,9 +461,13 @@ public class IvyResolveTest {
assertFalse(project.getProperty("ivy.resolved.configurations").contains("default"));
}
+ /**
+ * Test case for IVY-396.
+ *
+ * @see IVY-396
+ */
@Test
public void testResolveWithAbsoluteFile() {
- // IVY-396
File ivyFile = new File("test/java/org/apache/ivy/ant/ivy-simple.xml");
resolve.getProject().setProperty("ivy.dep.file", ivyFile.getAbsolutePath());
resolve.execute();
@@ -455,9 +476,13 @@ public class IvyResolveTest {
ModuleRevisionId.newInstance("apache", "resolve-simple", "1.0")).exists());
}
+ /**
+ * Test case for IVY-396.
+ *
+ * @see IVY-396
+ */
@Test
public void testResolveWithRelativeFile() {
- // IVY-396
resolve.getProject().setProperty("ivy.dep.file",
"test/java/org/apache/ivy/ant/ivy-simple.xml");
resolve.execute();
@@ -615,7 +640,7 @@ public class IvyResolveTest {
/**
* Test a failing resolve.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testChildsFail() throws Exception {
diff --git a/test/java/org/apache/ivy/ant/IvyRetrieveTest.java b/test/java/org/apache/ivy/ant/IvyRetrieveTest.java
index 422513d5..692360ad 100644
--- a/test/java/org/apache/ivy/ant/IvyRetrieveTest.java
+++ b/test/java/org/apache/ivy/ant/IvyRetrieveTest.java
@@ -89,9 +89,14 @@ public class IvyRetrieveTest {
"mod3.2", "jar", "jar", "private")).exists());
}
+ /**
+ * Test case for IVY-992.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-992
+ */
@Test
public void testValidateInIvySettings() throws Exception {
- // cfr IVY-992
project.setProperty("ivy.dep.file", "test/java/org/apache/ivy/ant/ivy-latest-extra.xml");
retrieve.getSettings().setValidate(false);
retrieve.execute();
@@ -222,9 +227,14 @@ public class IvyRetrieveTest {
"mod1.2", "jar", "jar")).exists());
}
+ /**
+ * Test case for IVY-304.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-304
+ */
@Test
public void testUseOrigin() throws Exception {
- // test case for IVY-304
// first we do a resolve with useOrigin=true in another project
Project project = TestHelper.newProject();
project.init();
@@ -268,6 +278,12 @@ public class IvyRetrieveTest {
"ivy", "ivy", "xml")).exists());
}
+ /**
+ * Test case for IVY-631.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-631
+ */
@Test
public void testRetrieveWithOriginalNamePattern() throws Exception {
retrieve.setFile(new File("test/java/org/apache/ivy/ant/ivy-631.xml"));
@@ -282,7 +298,7 @@ public class IvyRetrieveTest {
/**
* Retrieve without previous resolve must fail.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testFailureWithoutAPreviousResolve() throws Exception {
@@ -295,7 +311,7 @@ public class IvyRetrieveTest {
/**
* Test must fail with default haltonfailure setting.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = BuildException.class)
public void testFailure() throws Exception {
@@ -392,9 +408,13 @@ public class IvyRetrieveTest {
assertFalse(new File("build/test/lib/default/unknown").exists());
}
+ /**
+ * Test case for IVY-315.
+ *
+ * @see IVY-315
+ */
@Test
public void testDoubleRetrieveWithDifferentConfigurations() {
- // IVY-315
project.setProperty("ivy.dep.file", "test/java/org/apache/ivy/ant/ivy-doubleretrieve.xml");
retrieve.setConf("compile");
diff --git a/test/java/org/apache/ivy/core/deliver/DeliverTest.java b/test/java/org/apache/ivy/core/deliver/DeliverTest.java
index 70dcd585..2b52e1ff 100644
--- a/test/java/org/apache/ivy/core/deliver/DeliverTest.java
+++ b/test/java/org/apache/ivy/core/deliver/DeliverTest.java
@@ -70,6 +70,12 @@ public class DeliverTest {
cache.mkdirs();
}
+ /**
+ * Test case for IVY-1111.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-1111
+ */
@Test
public void testIVY1111() throws Exception {
Project project = ivyDeliver.getProject();
diff --git a/test/java/org/apache/ivy/core/module/descriptor/IvyMakePomTest.java b/test/java/org/apache/ivy/core/module/descriptor/IvyMakePomTest.java
index 04c06e4c..9bad4bd3 100644
--- a/test/java/org/apache/ivy/core/module/descriptor/IvyMakePomTest.java
+++ b/test/java/org/apache/ivy/core/module/descriptor/IvyMakePomTest.java
@@ -55,11 +55,13 @@ public class IvyMakePomTest {
}
/**
- * Tests that a Ivy file containing a classifier extra-attribute in its dependency, when converted to a
- * POM file through {@link IvyMakePom}, retains the classifier in the generated POM
+ * Test case for IVY-1528.
+ * An Ivy file containing a classifier extra attribute in its dependency,
+ * must retain the classifier in the generated POM when converted to
+ * a POM file through {@link IvyMakePom}.
*
- * @throws Exception
- * @see IVY-1528 for more details
+ * @throws Exception if something goes wrong
+ * @see IVY-1528
*/
@Test
public void testClassifier() throws Exception {
diff --git a/test/java/org/apache/ivy/core/publish/PublishEventsTest.java b/test/java/org/apache/ivy/core/publish/PublishEventsTest.java
index cdc5d918..1f014b17 100644
--- a/test/java/org/apache/ivy/core/publish/PublishEventsTest.java
+++ b/test/java/org/apache/ivy/core/publish/PublishEventsTest.java
@@ -178,6 +178,8 @@ public class PublishEventsTest {
/**
* Test a simple artifact publish, without errors or overwrite settings.
+ *
+ * @throws IOException if something goes wrong
*/
@Test
public void testPublishNoOverwrite() throws IOException {
@@ -197,6 +199,8 @@ public class PublishEventsTest {
/**
* Test a simple artifact publish, with overwrite set to true.
+ *
+ * @throws IOException if something goes wrong
*/
@Test
public void testPublishWithOverwrite() throws IOException {
@@ -220,6 +224,8 @@ public class PublishEventsTest {
/**
* Test an attempted publish with an invalid data file path.
+ *
+ * @throws IOException if something goes wrong
*/
@Test
public void testPublishMissingFile() throws IOException {
diff --git a/test/java/org/apache/ivy/core/resolve/ResolveTest.java b/test/java/org/apache/ivy/core/resolve/ResolveTest.java
index 194d3086..0ad84b18 100644
--- a/test/java/org/apache/ivy/core/resolve/ResolveTest.java
+++ b/test/java/org/apache/ivy/core/resolve/ResolveTest.java
@@ -350,9 +350,14 @@ public class ResolveTest {
assertTrue(report.hasError());
}
+ /**
+ * Test case for IVY-258.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-258
+ */
@Test
public void testResolveNoRevisionNowhere() throws Exception {
- // test case for IVY-258
// module1 depends on latest version of module2, which contains no revision in its ivy file,
// nor in the pattern
Ivy ivy = new Ivy();
@@ -367,9 +372,14 @@ public class ResolveTest {
assertFalse(report.hasError());
}
+ /**
+ * Test case for IVY-448.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-448
+ */
@Test
public void testResolveWithConflictManagerPerModule() throws Exception {
- // test case for IVY-448
// all modules from myorg
// module1
// -> module2-1.0
@@ -391,9 +401,14 @@ public class ResolveTest {
.exists());
}
+ /**
+ * Test case for IVY-465.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-465
+ */
@Test
public void testResolveWithConflictManagerDefinedInModule() throws Exception {
- // test case for IVY-465
// #M1;1.0 -> #M2;1.0
// #M2;1.0 -> {org1#mod1.2;1.1 org1#mod1.2;2.0} with
// * The test does the following: * - Resolves a module, let's call it "irrelevant-A" which has a dependency on "org:foo-bar:1.2.3" *
* - Invokes a retrieve RT1, with {@link RetrieveOptions#setMakeSymlinks(boolean) symlinks true} - * on that resolved module with a pattern that translates to a path "a/b/c/foo-bar.jar". When the RT1 retrieve is - * done, the path "a/b/c/foo-bar.jar" will be a symlink to a path "repo/cache/org/foo-bar/foo-bar-1.2.3.jar" in the - * Ivy cache. + * on that resolved module with a pattern that translates to a path "a/b/c/foo-bar.jar". When the + * RT1 retrieve is done, the path "a/b/c/foo-bar.jar" will be a symlink to a path + * "repo/cache/org/foo-bar/foo-bar-1.2.3.jar" in the Ivy cache. * All fine so far. *
- * - We then resolve another module, let's call it "irrelevant-B" which has a dependency on "org:foo-bar:2.3.4" + * - We then resolve another module, let's call it "irrelevant-B" which has a dependency on + * "org:foo-bar:2.3.4" *
* - Next, do a new retrieve RT2, on this newly resolved module with - * {@link RetrieveOptions#setMakeSymlinks(boolean) symlinks false} and {@link RetrieveOptions#getOverwriteMode() - * overwrite semantics enabled} and with the same pattern as before), that translates to a path "a/b/c/foo-bar.jar". + * {@link RetrieveOptions#setMakeSymlinks(boolean) symlinks false} and + * {@link RetrieveOptions#getOverwriteMode() overwrite semantics enabled} + * and with the same pattern as before), that translates to a path "a/b/c/foo-bar.jar". *
- * When RT2 retrieve is done, we expect the path "a/b/c/foo-bar.jar" will *not* be a symlink and instead be an actual file that represents - * the org:foo-bar:2.3.4 artifact jar. + * When RT2 retrieve is done, we expect the path "a/b/c/foo-bar.jar" will *not* be a symlink and + * instead be an actual file that represents the org:foo-bar:2.3.4 artifact jar. *
- * We also expect that this RT2 retrieve will not update/overwrite the file at path "repo/cache/org/foo-bar/foo-bar-1.2.3.jar"
- * in the Ivy cache - the file that was the end target of the symlink generated by the previous RT1.
+ * We also expect that this RT2 retrieve will not update/overwrite the file at path
+ * "repo/cache/org/foo-bar/foo-bar-1.2.3.jar" in the Ivy cache - the file that was the end
+ * target of the symlink generated by the previous RT1.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
* @see IVY-1498
*/
@Test
diff --git a/test/java/org/apache/ivy/core/settings/XmlSettingsParserTest.java b/test/java/org/apache/ivy/core/settings/XmlSettingsParserTest.java
index 6a271a43..71c935de 100644
--- a/test/java/org/apache/ivy/core/settings/XmlSettingsParserTest.java
+++ b/test/java/org/apache/ivy/core/settings/XmlSettingsParserTest.java
@@ -261,7 +261,7 @@ public class XmlSettingsParserTest {
/**
* Test of resolver referencing a non existent cache.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testInvalidCache() throws Exception {
@@ -400,9 +400,14 @@ public class XmlSettingsParserTest {
ivyPatterns.get(0));
}
+ /**
+ * Test case for IVY-319.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-319
+ */
@Test
public void testMacroAndRef() throws Exception {
- // test case for IVY-319
IvySettings settings = new IvySettings();
XmlSettingsParser parser = new XmlSettingsParser(settings);
parser.parse(XmlSettingsParserTest.class.getResource("ivysettings-macro+ref.xml"));
@@ -423,9 +428,14 @@ public class XmlSettingsParserTest {
assertTrue(shared instanceof FileSystemResolver);
}
+ /**
+ * Test case for IVY-860.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-860
+ */
@Test
public void testMacroAndRef2() throws Exception {
- // test case for IVY-860
IvySettings settings = new IvySettings();
XmlSettingsParser parser = new XmlSettingsParser(settings);
parser.parse(XmlSettingsParserTest.class.getResource("ivysettings-macro+ref2.xml"));
@@ -646,10 +656,11 @@ public class XmlSettingsParserTest {
}
/**
- * Tests that a Stephen Nesbitt<ttl> containing the matcher attribute, in a ivy settings file,
- * works as expected.
+ * Test case for IVY-1495.
+ * <ttl> containing the matcher attribute,
+ * in an ivy settings file, must work as expected.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
* @see IVY-1495
*/
@Test
@@ -673,7 +684,7 @@ public class XmlSettingsParserTest {
/**
* Tests that the timeout-constraint elements in a Ivy settings file are parsed correctly
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testTimeoutConstraints() throws Exception {
@@ -707,10 +718,10 @@ public class XmlSettingsParserTest {
}
/**
- * Tests that timeout constraints referenced by resolvers, in an ivy settings file, are processed correctly and the
- * corresponding resolvers use the right timeout constraints
+ * Tests that timeout constraints referenced by resolvers, in an ivy settings file, are
+ * processed correctly and the corresponding resolvers use the right timeout constraints
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testResolverTimeoutConstraintRefs() throws Exception {
diff --git a/test/java/org/apache/ivy/core/sort/SortTest.java b/test/java/org/apache/ivy/core/sort/SortTest.java
index 33031b86..00597755 100644
--- a/test/java/org/apache/ivy/core/sort/SortTest.java
+++ b/test/java/org/apache/ivy/core/sort/SortTest.java
@@ -90,8 +90,10 @@ public class SortTest {
/**
* Sorter does not throw circular dependency, circular dependencies are handled at resolve time
- * only. However the sort respect the transitive order when it is unambiguous. (if A depends
- * transitively of B, but B doesn't depends transitively on A then B always comes before A).
+ * only. However the sort respect the transitive order when it is unambiguous. (If A depends
+ * transitively of B, but B doesn't depends transitively on A, then B always comes before A.)
+ *
+ * @throws Exception if something goes wrong
*/
@Test
public void testCircularDependency() throws Exception {
@@ -127,7 +129,12 @@ public class SortTest {
}
}
- // Test IVY-624
+ /**
+ * Test case for IVY-624
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-624
+ */
@Test
public void testCircularDependencyInfiniteLoop() throws Exception {
addDependency(md1, "md2", "rev2");
@@ -213,8 +220,8 @@ public class SortTest {
/**
* When the version asked by a dependency is not compatible with the version declared in the
- * module to order, the two modules should be considered as independent NB: I'm sure of what
- * 'compatible' means !
+ * module to order, the two modules should be considered as independent.
+ * NB: I'm sure of what 'compatible' means !
*/
@Test
public void testDifferentVersionNotConsidered() {
@@ -339,7 +346,9 @@ public class SortTest {
fail(errorMessage.toString());
}
- /** Returns a collection of lists that contains the elements a,b,c and d */
+ /**
+ * Returns a collection of lists that contains the elements a, b, c and d
+ */
private Collection> getAllLists(ModuleDescriptor a, ModuleDescriptor b,
ModuleDescriptor c, ModuleDescriptor d) {
final int nbOfList = 24;
diff --git a/test/java/org/apache/ivy/osgi/core/OSGiManifestParserTest.java b/test/java/org/apache/ivy/osgi/core/OSGiManifestParserTest.java
index 60971a43..bddb05ec 100644
--- a/test/java/org/apache/ivy/osgi/core/OSGiManifestParserTest.java
+++ b/test/java/org/apache/ivy/osgi/core/OSGiManifestParserTest.java
@@ -72,10 +72,10 @@ public class OSGiManifestParserTest extends AbstractModuleDescriptorParserTester
}
/**
- * Tests that the {@link OSGiManifestParser#parseDescriptor(ParserSettings, URL, Resource, boolean)} works fine for descriptors
- * that are backed by {@link FileResource}
+ * Tests that the {@link OSGiManifestParser#parseDescriptor(ParserSettings, URL, Resource, boolean)}
+ * works fine for descriptors that are backed by {@link FileResource}
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testFileResource() throws Exception {
diff --git a/test/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManagerTest.java b/test/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManagerTest.java
index 104c63b0..37f476cc 100644
--- a/test/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManagerTest.java
+++ b/test/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManagerTest.java
@@ -139,7 +139,7 @@ public class LatestCompatibleConflictManagerTest {
/**
* Resolve must fail with a conflict.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = StrictConflictException.class)
public void testConflict() throws Exception {
@@ -152,7 +152,7 @@ public class LatestCompatibleConflictManagerTest {
/**
* Resolve must fail with a conflict.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = StrictConflictException.class)
public void testDynamicRootConflict() throws Exception {
diff --git a/test/java/org/apache/ivy/plugins/conflict/LatestConflictManagerTest.java b/test/java/org/apache/ivy/plugins/conflict/LatestConflictManagerTest.java
index 03a99421..3fd6d3f7 100644
--- a/test/java/org/apache/ivy/plugins/conflict/LatestConflictManagerTest.java
+++ b/test/java/org/apache/ivy/plugins/conflict/LatestConflictManagerTest.java
@@ -54,7 +54,12 @@ public class LatestConflictManagerTest {
FileUtil.forceDelete(_cache);
}
- // Test case for issue IVY-388
+ /**
+ * Test case for IVY-388.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-388
+ */
@Test
public void testIvy388() throws Exception {
ResolveReport report = ivy.resolve(
@@ -78,7 +83,12 @@ public class LatestConflictManagerTest {
}
}
- // Test case for issue IVY-383
+ /**
+ * Test case for IVY-383.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-383
+ */
@Test
public void testIvy383() throws Exception {
ResolveReport report = ivy.resolve(
@@ -93,7 +103,12 @@ public class LatestConflictManagerTest {
}
}
- // Test case for issue IVY-407
+ /**
+ * Test case for IVY-407.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-407
+ */
@Test
public void testLatestTime1() throws Exception {
ivy = new Ivy();
@@ -146,12 +161,19 @@ public class LatestConflictManagerTest {
}
}
- /*
- * Test case for issue IVY-407 (with transitivity) There are 5 modules A, B, C, D and E. 1)
- * publish C-1.0.0, C-1.0.1 and C-1.0.2 2) B needs C-1.0.0 : retrieve ok and publish B-1.0.0 3)
- * A needs B-1.0.0 and C-1.0.2 : retrieve ok and publish A-1.0.0 4) D needs C-1.0.1 : retrieve
- * ok and publish D-1.0.0 5) E needs D-1.0.0 and A-1.0.0 (D before A in ivy file) retrieve
- * failed to get C-1.0.2 from A (get apparently C-1.0.1 from D)
+ /**
+ * Test case for IVY-407 (with transitivity). There are 5 modules A, B, C, D and E.
+ *
+ *
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-407
*/
@Test
public void testLatestTimeTransitivity() throws Exception {
@@ -187,9 +209,10 @@ public class LatestConflictManagerTest {
}
}
- /*
- * Test case for issue IVY-1399:
+ /**
+ * Test case for IVY-1399.
* Dependency tree:
+ *
* Mycompany#target;1
* MyCompany#A;1
* conflicting-dependency#dep;1
@@ -202,6 +225,10 @@ public class LatestConflictManagerTest {
* ...
* MyCompany#C;1
* conflicting-dependency#dep;1
+ *
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-1399
*/
@Test
public void testEvictedModules() throws Exception {
diff --git a/test/java/org/apache/ivy/plugins/conflict/StrictConflictManagerTest.java b/test/java/org/apache/ivy/plugins/conflict/StrictConflictManagerTest.java
index 0851a87c..5f14e9c2 100644
--- a/test/java/org/apache/ivy/plugins/conflict/StrictConflictManagerTest.java
+++ b/test/java/org/apache/ivy/plugins/conflict/StrictConflictManagerTest.java
@@ -67,7 +67,7 @@ public class StrictConflictManagerTest {
/**
* Resolve must fail with a conflict.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = StrictConflictException.class)
public void testConflictResolve() throws Exception {
@@ -78,7 +78,7 @@ public class StrictConflictManagerTest {
/**
* Resolve must fail with a conflict.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = StrictConflictException.class)
public void testConflictWithDynamicRevisionResolve() throws Exception {
diff --git a/test/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParserTest.java b/test/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParserTest.java
index 3ed867b9..f51376da 100644
--- a/test/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParserTest.java
+++ b/test/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParserTest.java
@@ -376,7 +376,12 @@ public class PomModuleDescriptorParserTest extends AbstractModuleDescriptorParse
dds[1].getDependencyRevisionId());
}
- // IVY-392
+ /**
+ * Test case for IVY-392.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-392
+ */
@Test
public void testDependenciesWithInactiveProfile() throws Exception {
ModuleDescriptor md = PomModuleDescriptorParser.getInstance().parseDescriptor(settings,
@@ -451,9 +456,14 @@ public class PomModuleDescriptorParserTest extends AbstractModuleDescriptorParse
md.getModuleRevisionId());
}
+ /**
+ * Test case for IVY-425.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-425
+ */
@Test
public void testVariables() throws Exception {
- // test case for IVY-425
ModuleDescriptor md = PomModuleDescriptorParser.getInstance().parseDescriptor(settings,
getClass().getResource("spring-hibernate3-2.0.2.pom"), false);
assertNotNull(md);
@@ -469,9 +479,14 @@ public class PomModuleDescriptorParserTest extends AbstractModuleDescriptorParse
dds[10].getDependencyRevisionId());
}
+ /**
+ * Test case for IVY-423.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-423
+ */
@Test
public void testDependenciesInProfile() throws Exception {
- // test case for IVY-423
ModuleDescriptor md = PomModuleDescriptorParser.getInstance().parseDescriptor(settings,
getClass().getResource("mule-module-builders-1.3.3.pom"), false);
assertNotNull(md);
@@ -481,9 +496,14 @@ public class PomModuleDescriptorParserTest extends AbstractModuleDescriptorParse
md.getModuleRevisionId());
}
+ /**
+ * Test case for IVY-424.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-424
+ */
@Test
public void testIVY424() throws Exception {
- // test case for IVY-424
ModuleDescriptor md = PomModuleDescriptorParser.getInstance().parseDescriptor(settings,
getClass().getResource("shale-tiger-1.1.0-SNAPSHOT.pom"), false);
assertNotNull(md);
@@ -634,9 +654,14 @@ public class PomModuleDescriptorParserTest extends AbstractModuleDescriptorParse
excludeAllTransitiveDepsDescriptor.isTransitive());
}
+ /**
+ * Test case for IVY-417.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-417
+ */
@Test
public void testWithPlugins() throws Exception {
- // test case for IVY-417
ModuleDescriptor md = PomModuleDescriptorParser.getInstance().parseDescriptor(settings,
getClass().getResource("mule-1.3.3.pom"), false);
assertNotNull(md);
@@ -683,7 +708,7 @@ public class PomModuleDescriptorParserTest extends AbstractModuleDescriptorParse
* Tests that if a module doesn't have a license specified, then parent pom's license (if any)
* is used for the child module
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testLicenseFromParent() throws Exception {
@@ -704,7 +729,7 @@ public class PomModuleDescriptorParserTest extends AbstractModuleDescriptorParse
* Tests that if a project explicitly specifies the licenses, then the licenses (if any) from
* its parent pom aren't applied to the child project
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testOverriddenLicense() throws Exception {
@@ -1059,10 +1084,11 @@ public class PomModuleDescriptorParserTest extends AbstractModuleDescriptorParse
}
/**
- * Tests that a pom.xml which has references to properties that are either set via environment variables or system
- * properties, has its properties evaluated correctly.
+ * Test case for IVY-1561.
+ * A pom.xml which has references to properties that are either set via environment variables
+ * or system properties, must have its properties evaluated correctly.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
* @see IVY-1561
*/
@Test
diff --git a/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorParserTest.java b/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorParserTest.java
index af2a6cd0..0694f531 100644
--- a/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorParserTest.java
+++ b/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorParserTest.java
@@ -200,8 +200,8 @@ public class XmlModuleDescriptorParserTest extends AbstractModuleDescriptorParse
/**
* Test must fail because of bad version.
*
- * @throws IOException
- * @throws ParseException
+ * @throws IOException if something goes wrong
+ * @throws ParseException if something goes wrong
*/
@Test(expected = ParseException.class)
public void testBadVersion() throws IOException, ParseException {
@@ -1090,9 +1090,10 @@ public class XmlModuleDescriptorParserTest extends AbstractModuleDescriptorParse
}
/**
- * IVY-442: test for parser failure.
+ * Test case for IVY-442: expect parser failure.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
+ * @see IVY-442
*/
@Test(expected = ParseException.class)
public void testWithNonExistingConfigInDependency() throws Exception {
@@ -1103,7 +1104,7 @@ public class XmlModuleDescriptorParserTest extends AbstractModuleDescriptorParse
/**
* Test for parser failure.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test(expected = ParseException.class)
public void testWithNonExistingConfigInPublications() throws Exception {
@@ -1112,9 +1113,10 @@ public class XmlModuleDescriptorParserTest extends AbstractModuleDescriptorParse
}
/**
- * IVY-441: test for parser failure.
+ * Test case for IVY-441: expect parser failure.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
+ * @see IVY-441
*/
@Test(expected = ParseException.class)
public void testWithExistingConfigsInPublicationsSeparatedBySemiColon() throws Exception {
@@ -1459,8 +1461,8 @@ public class XmlModuleDescriptorParserTest extends AbstractModuleDescriptorParse
* as encoded characters (for example %2F) then the module descriptor and the location of
* the parent descriptor, are resolved and parsed correctly.
*
- * @throws Exception
- * @see IVY-1562 for more details
+ * @throws Exception if something goes wrong
+ * @see IVY-1562
*/
@Test
public void testExtendsAbsoluteLocation() throws Exception {
diff --git a/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorWriterTest.java b/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorWriterTest.java
index 14edef1f..341b569e 100644
--- a/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorWriterTest.java
+++ b/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorWriterTest.java
@@ -189,10 +189,10 @@ public class XmlModuleDescriptorWriterTest {
/**
* Test that the transitive attribute is written for non-transitive configurations.
*
- *
+ * <conf ... transitive="false" ... />
*
+ * @throws Exception if something goes wrong
* @see IVY-1207
- * @throws Exception
*/
@Test
public void testTransitiveAttributeForNonTransitiveConfs() throws Exception {
@@ -219,8 +219,8 @@ public class XmlModuleDescriptorWriterTest {
* This is the default and writing it will only add noise and cause a deviation from the known
* behavior (before fixing IVY-1207).
*
+ * @throws Exception if something goes wrong
* @see IVY-1207
- * @throws Exception
*/
@Test
public void testTransitiveAttributeNotWrittenForTransitiveConfs() throws Exception {
diff --git a/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleUpdaterTest.java b/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleUpdaterTest.java
index bb582d0f..233b4e6a 100644
--- a/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleUpdaterTest.java
+++ b/test/java/org/apache/ivy/plugins/parser/xml/XmlModuleUpdaterTest.java
@@ -337,7 +337,12 @@ public class XmlModuleUpdaterTest {
}
}
- // IVY-1356
+ /**
+ * Test case for IVY-1356.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-1356
+ */
@Test
public void testMergedUpdateWithExtendsAndExcludes() throws Exception {
URL url = XmlModuleUpdaterTest.class.getResource("test-extends-dependencies-exclude.xml");
diff --git a/test/java/org/apache/ivy/plugins/repository/vfs/VfsRepositoryTest.java b/test/java/org/apache/ivy/plugins/repository/vfs/VfsRepositoryTest.java
index fe2fae47..e5cd9b8e 100644
--- a/test/java/org/apache/ivy/plugins/repository/vfs/VfsRepositoryTest.java
+++ b/test/java/org/apache/ivy/plugins/repository/vfs/VfsRepositoryTest.java
@@ -29,19 +29,29 @@ import org.junit.Test;
import static org.junit.Assert.*;
/**
- * Testing Testing was the single biggest hurdle I faced. I have tried to provide a complete test
+ * Testing was the single biggest hurdle I faced. I have tried to provide a complete test
* suite that covers all protocols and which can be easily extended. It does differ - somewhat - in
* structure from the resolver/repository test suites. Setting up smb, ftp, sftp will undoubtedly be
- * your biggest headache (it was mine). Here are a few notes about the setup: - the VFS test suite
- * uses the build/test/repositories area - when setting samba, sftp, etc. the corresponding user
- * needs both read and write privileges. - the tests assume that the user and password is the same
- * for all services. - a limited amount of configuration is available by setting the following
- * properties in the ivy.properties file: * vfs.host * vfs.username * vfs.password * vfs.samba_share
- * Running the test requires that commons-io and ant.jar are on the classpath. Also, I would
- * recommend that at some time the tests be converted from straight junit to something which betters
- * supports functional testing. Although somewhat crude I am using jsystem
+ * your biggest headache (it was mine). Here are a few notes about the setup:
+ *
+ *
+ * ivy.properties file:
+ * vfs.host
+ * vfs.username
+ * vfs.password
+ * vfs.samba_share
+ *
+ * Running the test requires that commons-io and ant jars are on the classpath. Also, I would
+ * recommend that at some time the tests be converted from straight junit to something which better
+ * supports functional testing. Although somewhat crude, I am using jsystem
* (http://jsystemtest.sourceforge.net/) in other projects and am finding it a much better solution
- * than straight junit. Stephen Nesbitt
+ * than straight junit.
+ * String representing a well formed VFS resource identifier
+ * @return String representing a well formed VFS resource identifier
*/
public String getVfsURI() {
StringBuilder uri = new StringBuilder();
diff --git a/test/java/org/apache/ivy/plugins/resolver/ChainResolverTest.java b/test/java/org/apache/ivy/plugins/resolver/ChainResolverTest.java
index c04894c2..e9f0dd19 100644
--- a/test/java/org/apache/ivy/plugins/resolver/ChainResolverTest.java
+++ b/test/java/org/apache/ivy/plugins/resolver/ChainResolverTest.java
@@ -326,9 +326,14 @@ public class ChainResolverTest extends AbstractDependencyResolverTest {
}
}
+ /**
+ * Test case for IVY-206.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-206
+ */
@Test
public void testFixedWithDefaultAndRealResolver() throws Exception {
- // test case for IVY-206
ChainResolver chain = new ChainResolver();
chain.setName("chain");
chain.setSettings(settings);
@@ -416,9 +421,14 @@ public class ChainResolverTest extends AbstractDependencyResolverTest {
}
}
+ /**
+ * Test case for IVY-389.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-389
+ */
@Test
public void testReturnFirstWithDefaultAndCacheAndRealResolver() throws Exception {
- // test case for IVY-389
DefaultDependencyDescriptor dd = new DefaultDependencyDescriptor(
ModuleRevisionId.newInstance("org1", "mod1.1", "1.0"), false);
@@ -437,10 +447,14 @@ public class ChainResolverTest extends AbstractDependencyResolverTest {
assertEquals(true, rmr.getDescriptor().isDefault());
}
+ /**
+ * Test case for IVY-207.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-207
+ */
public void testReturnFirstWithCheckModifiedAndDefaultAndCacheAndRealResolver()
throws Exception {
- // test case for IVY-207
-
DefaultDependencyDescriptor dd = new DefaultDependencyDescriptor(
ModuleRevisionId.newInstance("org1", "mod1.1", "1.0"), false);
diff --git a/test/java/org/apache/ivy/plugins/resolver/DualResolverTest.java b/test/java/org/apache/ivy/plugins/resolver/DualResolverTest.java
index 8a7b5b2d..6ed58538 100644
--- a/test/java/org/apache/ivy/plugins/resolver/DualResolverTest.java
+++ b/test/java/org/apache/ivy/plugins/resolver/DualResolverTest.java
@@ -87,8 +87,8 @@ public class DualResolverTest extends AbstractDependencyResolverTest {
/**
* Test fails due to bad resolver configuration.
*
- * @throws IOException
- * @throws ParseException
+ * @throws IOException if something goes wrong
+ * @throws ParseException if something goes wrong
*/
@Test(expected = ParseException.class)
public void testFromBadConf() throws IOException, ParseException {
@@ -99,7 +99,7 @@ public class DualResolverTest extends AbstractDependencyResolverTest {
/**
* Test fails due to bad resolver configuration
*
- * @throws ParseException
+ * @throws ParseException if something goes wrong
*/
@Test(expected = IllegalStateException.class)
public void testBad() throws ParseException {
diff --git a/test/java/org/apache/ivy/plugins/resolver/FileSystemResolverTest.java b/test/java/org/apache/ivy/plugins/resolver/FileSystemResolverTest.java
index a0cbd711..6446d9c8 100644
--- a/test/java/org/apache/ivy/plugins/resolver/FileSystemResolverTest.java
+++ b/test/java/org/apache/ivy/plugins/resolver/FileSystemResolverTest.java
@@ -165,9 +165,14 @@ public class FileSystemResolverTest extends AbstractDependencyResolverTest {
assertEquals(DownloadStatus.NO, ar.getDownloadStatus());
}
+ /**
+ * Test case for IVY-676.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-676
+ */
@Test
public void testFindIvyFileRefWithMultipleIvyPatterns() throws Exception {
- // cfr IVY-676
FileSystemResolver resolver = new FileSystemResolver();
resolver.setName("test");
resolver.setSettings(settings);
@@ -263,7 +268,8 @@ public class FileSystemResolverTest extends AbstractDependencyResolverTest {
/**
* Tests that SHA-256 algorithm can be used for checksums on resolvers
- * @throws Exception
+ *
+ * @throws Exception if something goes wrong
*/
@Test
public void testSHA256Checksum() throws Exception {
@@ -294,7 +300,7 @@ public class FileSystemResolverTest extends AbstractDependencyResolverTest {
/**
* Tests that SHA-512 algorithm can be used for checksums on resolvers
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testSHA512Checksum() throws Exception {
@@ -887,7 +893,7 @@ public class FileSystemResolverTest extends AbstractDependencyResolverTest {
/**
* Publishing with transaction=true and an unsupported pattern must fail.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testUnsupportedTransaction() throws Exception {
@@ -916,7 +922,7 @@ public class FileSystemResolverTest extends AbstractDependencyResolverTest {
/**
* Publishing with transaction=true and an unsupported combination of patterns must fail.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testUnsupportedTransaction2() throws Exception {
@@ -948,7 +954,7 @@ public class FileSystemResolverTest extends AbstractDependencyResolverTest {
/**
* Publishing with transaction=true and overwrite mode must fail.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testUnsupportedTransaction3() throws Exception {
diff --git a/test/java/org/apache/ivy/plugins/resolver/IvyRepResolverTest.java b/test/java/org/apache/ivy/plugins/resolver/IvyRepResolverTest.java
index 6091f5eb..bce5415f 100644
--- a/test/java/org/apache/ivy/plugins/resolver/IvyRepResolverTest.java
+++ b/test/java/org/apache/ivy/plugins/resolver/IvyRepResolverTest.java
@@ -95,9 +95,10 @@ public class IvyRepResolverTest extends AbstractDependencyResolverTest {
}
/**
- * IVY-625: should fail if no ivyroot specified.
+ * Test case for IVY-625. Must fail if no ivyroot specified.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
+ * @see IVY-625
*/
@Test
public void testMandatoryRoot() throws Exception {
diff --git a/test/java/org/apache/ivy/plugins/resolver/URLResolverTest.java b/test/java/org/apache/ivy/plugins/resolver/URLResolverTest.java
index f8945989..7b11e4e1 100644
--- a/test/java/org/apache/ivy/plugins/resolver/URLResolverTest.java
+++ b/test/java/org/apache/ivy/plugins/resolver/URLResolverTest.java
@@ -383,7 +383,7 @@ public class URLResolverTest extends AbstractDependencyResolverTest {
/**
* Tests that the timeout constraint set on the URL resolver is used correctly by the resolver
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testTimeoutConstraint() throws Exception {
diff --git a/test/java/org/apache/ivy/util/TestXmlHelper.java b/test/java/org/apache/ivy/util/TestXmlHelper.java
index cea9e0bc..440e35a0 100644
--- a/test/java/org/apache/ivy/util/TestXmlHelper.java
+++ b/test/java/org/apache/ivy/util/TestXmlHelper.java
@@ -40,7 +40,7 @@ public class TestXmlHelper {
* @param xPathExpression The XPath expression to evaluate
* @param returnType The expected return type of the {@link XPathExpression#evaluate(Object, QName) evaluation}
* @return The result
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
public static Object evaluateXPathExpr(final File xmlFile, final XPathExpression xPathExpression, final QName returnType)
throws Exception {
@@ -67,7 +67,7 @@ public class TestXmlHelper {
* @param xpathExpression The XPath expression to evaluate
* @param returnType The expected return type of the {@link XPathExpression#evaluate(Object, QName) evaluation}
* @return The result
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
public static Object evaluateXPathExpr(final File xmlFile, final String xpathExpression, final QName returnType) throws Exception {
return evaluateXPathExpr(xmlFile, XPathFactory.newInstance().newXPath().compile(xpathExpression), returnType);
diff --git a/test/java/org/apache/ivy/util/url/AbstractURLHandlerTest.java b/test/java/org/apache/ivy/util/url/AbstractURLHandlerTest.java
index d30f1dd0..e792c046 100644
--- a/test/java/org/apache/ivy/util/url/AbstractURLHandlerTest.java
+++ b/test/java/org/apache/ivy/util/url/AbstractURLHandlerTest.java
@@ -32,7 +32,10 @@ import static org.junit.Assert.assertEquals;
public class AbstractURLHandlerTest {
/**
- * JUnit test for IVY-923.
+ * Test case for IVY-923.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-923
*/
@Test
public void testNormalizeToStringWithSpaceURL() throws Exception {
@@ -43,7 +46,10 @@ public class AbstractURLHandlerTest {
}
/**
- * JUnit test for IVY-923.
+ * Test case for IVY-923.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-923
*/
@Test
public void testNormalizeToStringWithPlusCharacter() throws Exception {
diff --git a/test/java/org/apache/ivy/util/url/ApacheURLListerTest.java b/test/java/org/apache/ivy/util/url/ApacheURLListerTest.java
index 6ab2543d..226a9202 100644
--- a/test/java/org/apache/ivy/util/url/ApacheURLListerTest.java
+++ b/test/java/org/apache/ivy/util/url/ApacheURLListerTest.java
@@ -33,7 +33,7 @@ public class ApacheURLListerTest {
/**
* Tests {@link ApacheURLLister#retrieveListing(URL, boolean, boolean)}.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testRetrieveListing() throws Exception {
@@ -62,7 +62,7 @@ public class ApacheURLListerTest {
/**
* Tests {@link ApacheURLLister#retrieveListing(URL, boolean, boolean)}.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
*/
@Test
public void testRetrieveListingWithSpaces() throws Exception {
diff --git a/test/java/org/apache/ivy/util/url/HttpclientURLHandlerTest.java b/test/java/org/apache/ivy/util/url/HttpclientURLHandlerTest.java
index de82269b..d63cf6d3 100644
--- a/test/java/org/apache/ivy/util/url/HttpclientURLHandlerTest.java
+++ b/test/java/org/apache/ivy/util/url/HttpclientURLHandlerTest.java
@@ -80,10 +80,15 @@ public class HttpclientURLHandlerTest {
assertFalse("URL resource was expected to be unreachable", handler.isReachable(new URL("http://www.google.fr/unknownpage.html"), defaultTimeoutConstraint));
}
+ /**
+ * Test case for IVY-390.
+ *
+ * @throws Exception if something goes wrong
+ * @see IVY-390
+ */
@SuppressWarnings("resource")
@Test
public void testGetURLInfo() throws Exception {
- // IVY-390
URLHandler handler = new HttpClientHandler();
URLInfo info = handler
.getURLInfo(new URL(
@@ -115,7 +120,7 @@ public class HttpclientURLHandlerTest {
* Tests that the {@link HttpClientHandler}, backed by {@link CredentialsStore Ivy credentials store}
* works as expected when it interacts with a HTTP server which requires authentication for accessing resources.
*
- * @throws Exception
+ * @throws Exception if something goes wrong
* @see IVY-1336
*/
@Test
diff --git a/test/java/org/apache/ivy/util/url/IvyAuthenticatorTest.java b/test/java/org/apache/ivy/util/url/IvyAuthenticatorTest.java
index 9817576b..002e68de 100644
--- a/test/java/org/apache/ivy/util/url/IvyAuthenticatorTest.java
+++ b/test/java/org/apache/ivy/util/url/IvyAuthenticatorTest.java
@@ -67,7 +67,7 @@ public class IvyAuthenticatorTest {
* relevant requesting information, including the {@link Authenticator#getRequestingURL() requesting URL} and
* {@link Authenticator#getRequestorType() request type}
*
- * @throws Exception
+ * @throws Exception if something goes wrong
* @see IVY-1557
*/
@Test