From fa15dbd2987db656aa7f4aa789084074315af4ba Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Tue, 21 Jul 2009 05:03:02 +0000
Subject: [PATCH] Ant's Bugzilla issue 39492 applies to AntUnit as well. 
 Properly escape XML in stacktraces

git-svn-id: https://svn.apache.org/repos/asf/ant/antlibs/antunit/trunk@796145 13f79535-47bb-0310-9956-ffa450edef68
---
 changes.xml                |  4 ++++
 src/etc/junit-frames.xsl   | 13 ++++++++++++-
 src/etc/junit-noframes.xsl | 13 ++++++++++++-
 3 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/changes.xml b/changes.xml
index 6d43760..c9e4a70 100644
--- a/changes.xml
+++ b/changes.xml
@@ -44,6 +44,10 @@
     <action type="update">
       expectfailure report the original build exception chained when failing
     </action>
+    <action type="fix">
+      Default XSLT stylesheets now properly escape XML in exception
+      stack traces.
+    </action>
   </release>
   
   <release version="1.1" date="2008-09-26">
diff --git a/src/etc/junit-frames.xsl b/src/etc/junit-frames.xsl
index 8a456b9..b52c035 100644
--- a/src/etc/junit-frames.xsl
+++ b/src/etc/junit-frames.xsl
@@ -873,7 +873,18 @@ h6 {
 -->
 <xsl:template name="br-replace">
     <xsl:param name="word"/>
-    <xsl:value-of disable-output-escaping="yes" select='stringutils:replace(string($word),"&#xA;","&lt;br/>")'/>
+    <xsl:choose>
+      <xsl:when test="contains($word, '&#xa;')">
+        <xsl:value-of select="substring-before($word, '&#xa;')"/>
+        <br/>
+        <xsl:call-template name="br-replace">
+          <xsl:with-param name="word" select="substring-after($word, '&#xa;')"/>
+        </xsl:call-template>
+      </xsl:when>
+      <xsl:otherwise>
+	<xsl:value-of select="$word"/>
+      </xsl:otherwise>
+    </xsl:choose>
 </xsl:template>
 
 <xsl:template name="display-time">
diff --git a/src/etc/junit-noframes.xsl b/src/etc/junit-noframes.xsl
index 7c29f17..901c671 100644
--- a/src/etc/junit-noframes.xsl
+++ b/src/etc/junit-noframes.xsl
@@ -468,7 +468,18 @@ under the License.
 -->
 <xsl:template name="br-replace">
     <xsl:param name="word"/>
-    <xsl:value-of disable-output-escaping="yes" select='stringutils:replace(string($word),"&#xA;","&lt;br/>")'/>
+    <xsl:choose>
+      <xsl:when test="contains($word, '&#xa;')">
+        <xsl:value-of select="substring-before($word, '&#xa;')"/>
+        <br/>
+        <xsl:call-template name="br-replace">
+          <xsl:with-param name="word" select="substring-after($word, '&#xa;')"/>
+        </xsl:call-template>
+      </xsl:when>
+      <xsl:otherwise>
+	<xsl:value-of select="$word"/>
+      </xsl:otherwise>
+    </xsl:choose>
 </xsl:template>
 
 <xsl:template name="display-time">