!1329 fix resource leak and path manipulation problem

Merge pull request !1329 from chenpingzeng/1230_rc1_release_safety_issue
This commit is contained in:
i-robot 2021-12-21 06:24:53 +00:00 committed by Gitee
commit b0fd71fbcb
4 changed files with 6 additions and 0 deletions

View File

@ -75,6 +75,7 @@ public class TestAssignUniqueIdOperator
assertEquals(SnapshotTestUtil.toSimpleSnapshotMapping(snapshot), createExpectedMapping());
assertEquals(output.getPositionCount(), 9);
assertEquals(output.getChannelCount(), 2);
operator.close();
}
private Map<String, Object> createExpectedMapping()

View File

@ -85,6 +85,7 @@ public class TestEnforceSingleRowOperator
}
assertTrue(caught, "Operator didn't catch input of position count 2.");
operator.close();
}
private Map<String, Object> createExpectedMapping()

View File

@ -84,6 +84,7 @@ public class TestCrossRegionDynamicFilterOperator
operator.addInput(pages.get(1));
Page page2 = operator.getOutput();
assertEquals(page2, pages.get(1));
operator.close();
}
@Test
@ -109,6 +110,7 @@ public class TestCrossRegionDynamicFilterOperator
Block block = page.getBlock(0).getLoadedBlock();
String nativeValue = TypeUtils.readNativeValueForDynamicFilter(types.get(0), block, 0);
assertEquals(nativeValue, "10001");
operator.close();
}
@Test
@ -132,6 +134,7 @@ public class TestCrossRegionDynamicFilterOperator
Page page = operator.getOutput();
assertEquals(page.getPositionCount(), 0);
operator.close();
}
private CrossRegionDynamicFilterOperator createBloomFilterOperator(String queryId, DynamicFilterCacheManager dynamicFilterCacheManager)

View File

@ -542,6 +542,7 @@ public class MemoryTableManager
public long getAllTablesDiskByteUsage() throws IOException
{
long totalBytes = 0L;
validateSpillRoot();
for (long id : tables.keySet()) {
long diskUsageSize = Files.walk(spillRoot.resolve(String.valueOf(id)))
.filter(p -> p.toFile().isFile())