gitlab/app/controllers/projects
Dmitriy Zaporozhets 28219ea921 Merge branch 'fix-raw-controller-disposition' into 'master'
Remove the filename argument from Content-Disposition header

This MR removes the filename argument from the `Content-Disposition` header to avoid RFC 5987 and RFC 6266 encoding issues. Some browsers (e.g. Internet Explorer) do not properly decode a Unicode string properly, and this can lead to odd filenames in the raw file download. This change allows the browser to determine the filename based on the URL.

For example, if I have a file called `한글한글.pptx` and click to download it with the "Raw" button in the Files section, IE11 will ask:

![image](https://gitlab.com/stanhu/gitlab-ce/uploads/fdb688282c0d4564872deadb44c58b2c/image.png)

If you look at the `Content-Disposition` field, you see this:

![image](https://gitlab.com/stanhu/gitlab-ce/uploads/2b342b83ae1ec61fd31937163ace8ec5/image.png)

Chrome, Firefox, and Safari seem to be able to handle UTF-8 encoded filenames, even though this is not standard.

See: http://greenbytes.de/tech/tc2231/

Closes https://github.com/gitlabhq/gitlabhq/issues/9595

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/1829

I've also submitted a pull request to Rails to support RFC 6266: https://github.com/rails/rails/pull/21461

See merge request !1235
2015-09-02 12:25:28 +00:00
..
application_controller.rb Add a page title to every page. 2015-04-30 19:12:15 +02:00
avatars_controller.rb Add a page title to every page. 2015-04-30 19:12:15 +02:00
blame_controller.rb Fix blame view line groupings 2015-08-20 01:27:29 -07:00
blob_controller.rb Revert "Merge branch 'revert-satellites' into 'master' " 2015-08-11 14:33:31 +02:00
branches_controller.rb Fix errors deleting and creating branches with encoded slashes 2015-08-01 23:33:33 -07:00
commit_controller.rb No longer needed to pass project argument to commit methods. 2015-04-24 12:29:36 +02:00
commits_controller.rb Fixed the Rails/ActionFilter cop 2015-04-20 15:39:37 +02:00
compare_controller.rb Revert "Merge branch 'revert-satellites' into 'master' " 2015-08-11 14:33:31 +02:00
deploy_keys_controller.rb Remove show actions from Admin and Project DeployKeys 2015-06-03 18:03:04 -04:00
forks_controller.rb Add a page title to every page. 2015-04-30 19:12:15 +02:00
graphs_controller.rb Add ref switching support for graphs 2015-07-06 16:44:30 +02:00
hooks_controller.rb Enable SSL verification for Webhooks 2015-08-26 15:48:31 +03:00
imports_controller.rb Fixed the Rails/ActionFilter cop 2015-04-20 15:39:37 +02:00
issues_controller.rb Disable internal issue tracker if external tracker in use 2015-07-17 22:59:31 -07:00
labels_controller.rb Fix 403 Access Denied error messages when accessing Labels section in a project that has MRs disabled but issues enabled 2015-06-18 03:15:05 -07:00
merge_requests_controller.rb Revert "Merge branch 'revert-satellites' into 'master' " 2015-08-11 14:33:31 +02:00
milestones_controller.rb Add support for destroying project milestones 2015-07-17 06:54:32 -07:00
network_controller.rb Fix network graph when branch name has single quotes 2015-07-29 23:29:47 -07:00
notes_controller.rb Show who last edited a comment if it wasn't the original author 2015-07-30 14:45:54 +02:00
project_members_controller.rb Move Project Members link from Settings to main menu. 2015-06-09 14:45:38 +02:00
protected_branches_controller.rb Fixed the Rails/ActionFilter cop 2015-04-20 15:39:37 +02:00
raw_controller.rb Remove the filename argument from Content-Disposition header to avoid 2015-09-02 00:20:05 -07:00
refs_controller.rb Fix commit data retrieval when branch name has single quotes 2015-07-26 03:47:01 -07:00
repositories_controller.rb Fixed the Rails/ActionFilter cop 2015-04-20 15:39:37 +02:00
services_controller.rb Drone CI service 2015-09-02 05:52:16 +03:00
snippets_controller.rb Fix 500 error when try to create project snippet without content 2015-08-26 23:59:52 +02:00
tags_controller.rb Fixed the Rails/ActionFilter cop 2015-04-20 15:39:37 +02:00
tree_controller.rb Fix 404 error in files view after deleting the last file in a repository 2015-07-21 14:12:43 -07:00
uploads_controller.rb Add a page title to every page. 2015-04-30 19:12:15 +02:00
wikis_controller.rb Update controller filters 2015-06-26 16:44:21 +02:00