Linus Torvalds 2390e3573a Revert "mm, slub: consider rest of partial list if acquire_slab() fails" ... commit 9b1ea29bc0d7b94d420f96a0f4121403efc3dd85 upstream. This reverts commit 8ff60eb052eeba95cfb3efe16b08c9199f8121cf. The kernel test robot reports a huge performance regression due to the commit, and the reason seems fairly straightforward: when there is contention on the page list (which is what causes acquire_slab() to fail), we do _not_ want to just loop and try again, because that will transfer the contention to the 'n->list_lock' spinlock we hold, and just make things even worse. This is admittedly likely a problem only on big machines - the kernel test robot report comes from a 96-thread dual socket Intel Xeon Gold 6252 setup, but the regression there really is quite noticeable: -47.9% regression of stress-ng.rawpkt.ops_per_sec and the commit that was marked as being fixed (7ced37197196: "slub: Acquire_slab() avoid loop") actually did the loop exit early very intentionally (the hint being that "avoid loop" part of that commit message), exactly to avoid this issue. The correct thing to do may be to pick some kind of reasonable middle ground: instead of breaking out of the loop on the very first sign of contention, or trying over and over and over again, the right thing may be to re-try _once_, and then give up on the second failure (or pick your favorite value for "once"..). Reported-by: kernel test robot <oliver.sang@intel.com> Link: https://lore.kernel.org/lkml/20210301080404.GF12822@xsang-OptiPlex-9020/ Cc: Jann Horn <jannh@google.com> Cc: David Rientjes <rientjes@google.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Acked-by: Christoph Lameter <cl@linux.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-04-12 12:52:58 +08:00
..
kasan	kasan: fix incorrect arguments passing in kasan_add_zero_shadow	2021-04-12 12:51:39 +08:00
Kconfig	mm/zsmalloc.c: drop ZSMALLOC_PGTABLE_MAPPING	2021-03-16 16:42:15 +08:00
Kconfig.debug	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
Makefile	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
backing-dev.c	bdi: add a ->dev_name field to struct backing_dev_info	2021-03-16 16:27:44 +08:00
balloon_compaction.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
cleancache.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
cma.c	cma: don't quit at first error when activating reserved areas	2021-03-16 16:34:57 +08:00
cma.h	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
cma_debug.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
compaction.c	mm/compaction: fix misbehaviors of fast_find_migrateblock()	2021-04-12 12:52:31 +08:00
debug.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
debug_page_ref.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
dmapool.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
early_ioremap.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
fadvise.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
failslab.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
filemap.c	mm/error_inject: Fix allow_error_inject function signatures.	2021-03-16 16:38:34 +08:00
frame_vector.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
frontswap.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
gup.c	mm/gup: fix gup_fast with dynamic page table folding	2021-03-16 16:37:40 +08:00
gup_benchmark.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
highmem.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
hmm.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
huge_memory.c	mm: thp: fix MADV_REMOVE deadlock on shmem THP	2021-04-12 12:51:57 +08:00
hugetlb.c	mm/hugetlb.c: fix unnecessary address expansion of pmd sharing	2021-04-12 12:52:44 +08:00
hugetlb_cgroup.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
hwpoison-inject.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
init-mm.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
internal.h	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
interval_tree.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
khugepaged.c	mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged	2021-03-16 16:38:06 +08:00
kmemleak-test.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
kmemleak.c	mm/kmemleak.c: use address-of operator on section symbols	2021-03-16 16:37:10 +08:00
ksm.c	mm/ksm: fix NULL pointer dereference when KSM zero page is enabled	2021-03-16 16:26:56 +08:00
list_lru.c	mm: list_lru: set shrinker map bit when child nr_items is not zero	2021-03-16 16:42:05 +08:00
maccess.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
madvise.c	mm: validate pmd after splitting	2021-03-16 16:37:37 +08:00
memblock.c	memblock: do not start bottom-up allocations with kernel_end	2021-04-12 12:51:54 +08:00
memcontrol.c	mm: memcg/slab: fix root memcg vmstats	2021-03-16 16:41:32 +08:00
memfd.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
memory-failure.c	BACKPORT: mm/memory-failure: Add memory_failure_queue_kick()	2021-03-16 16:43:59 +08:00
memory.c	hugetlb: fix copy_huge_page_from_user contig page struct assumption	2021-04-12 12:52:39 +08:00
memory_hotplug.c	mm: don't rely on system state to detect hot-plug operations	2021-03-16 16:37:50 +08:00
mempolicy.c	mm: mempolicy: fix potential pte_unmap_unlock pte error	2021-03-16 16:40:21 +08:00
mempool.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
memremap.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
memtest.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
migrate.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
mincore.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
mlock.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
mm_init.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
mmap.c	mm/mmap.c: initialize align_offset explicitly for vm_unmapped_area	2021-03-16 16:37:12 +08:00
mmu_context.c	mm: fix kthread_use_mm() vs TLB invalidate	2021-03-16 16:34:57 +08:00
mmu_gather.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
mmu_notifier.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
mmzone.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
mprotect.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
mremap.c	mm: Fix mremap not considering huge pmd devmap	2021-03-16 16:28:43 +08:00
msync.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
nommu.c	mm: Implement no-MMU variant of vmalloc_user_node_flags	2021-03-16 16:43:58 +08:00
oom_kill.c	mm, oom_adj: don't loop through tasks in __set_oom_adj when not necessary	2021-03-16 16:38:47 +08:00
page-writeback.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
page_alloc.c	mm: don't wake kswapd prematurely when watermark boosting is disabled	2021-03-16 16:43:15 +08:00
page_counter.c	mm/page_counter.c: fix protection usage propagation	2021-03-16 16:34:07 +08:00
page_ext.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
page_idle.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
page_io.c	swap: fix swapfile read/write offset	2021-04-12 12:52:50 +08:00
page_isolation.c	mm/memory_hotplug: drain per-cpu pages again during memory offline	2021-03-16 16:36:22 +08:00
page_owner.c	mm/page_owner: change split_page_owner to take a count	2021-03-16 16:38:58 +08:00
page_poison.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
page_vma_mapped.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
pagewalk.c	mm: pagewalk: fix termination condition in walk_pte_range()	2021-03-16 16:36:50 +08:00
percpu-internal.h	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
percpu-km.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
percpu-stats.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
percpu-vm.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
percpu.c	percpu: fix first chunk size calculation for populated bitmap	2021-03-16 16:36:21 +08:00
pgtable-generic.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
process_vm_access.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
readahead.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
rmap.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
rodata_test.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
shmem.c	shmem: fix possible deadlocks on shmlock_user_lock	2021-03-16 16:27:44 +08:00
shuffle.c	mm/shuffle: don't move pages between zones and don't read garbage memmaps	2021-03-16 16:34:57 +08:00
shuffle.h	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
slab.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
slab.h	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
slab_common.c	mm: memcg/slab: fix memory leak at non-root kmem_cache destroy	2021-03-16 16:32:38 +08:00
slob.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
slub.c	Revert "mm, slub: consider rest of partial list if acquire_slab() fails"	2021-04-12 12:52:58 +08:00
sparse-vmemmap.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
sparse.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
swap.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
swap_cgroup.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
swap_slots.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
swap_state.c	mm/swap_state: fix a data race in swapin_nr_pages	2021-03-16 16:37:24 +08:00
swapfile.c	swap: fix swapfile read/write offset	2021-04-12 12:52:50 +08:00
truncate.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
usercopy.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
userfaultfd.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
util.c	mm: add kvfree_sensitive() for freeing sensitive data objects	2021-03-16 16:28:58 +08:00
vmacache.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
vmalloc.c	bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY	2021-03-16 16:43:58 +08:00
vmpressure.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
vmscan.c	pagecachelimit: remove unused function to fix the compile warning	2021-03-16 16:43:57 +08:00
vmstat.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
workingset.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
z3fold.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
zbud.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
zpool.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00
zsmalloc.c	zsmalloc: account the number of compacted pages correctly	2021-04-12 12:52:50 +08:00
zswap.c	Init Repo base on linux 5.4.32 long term, and add base tlinux kernel interfaces.	2021-03-16 11:01:34 +08:00