From 9b82841082f8d683fe92b37e938edd14d89f4b5c Mon Sep 17 00:00:00 2001 From: whzy <2402686765@qq.com> Date: Sat, 27 Jun 2026 20:55:42 +0800 Subject: [PATCH] docs(feishu): finalize non-image PR validation notes --- docs/pr-draft.md | 29 +++++++++++++++++++++++++++++ reports/FEISHU_SMOKE_20260627.md | 29 ++++++++++++++++++++--------- 2 files changed, 49 insertions(+), 9 deletions(-) diff --git a/docs/pr-draft.md b/docs/pr-draft.md index 6ff3c57..9510edd 100644 --- a/docs/pr-draft.md +++ b/docs/pr-draft.md @@ -137,10 +137,39 @@ go run . feishu +bitable-sync --from-workflow-json .local\report.json --send --f go test ./shortcuts/feishu go test ./shortcuts/workflow +go test ./shortcuts go test ./... +go build . go vet ./... ``` +Local validation on 2026-06-27: + +```text +go test ./shortcuts/feishu: pass +go test ./shortcuts/workflow: pass +go test ./shortcuts: pass +go test ./...: pass +go build .: pass +go vet ./...: pass +``` + +CI note: + +```text +.github/workflows/test.yml already includes the upstream i18n validation steps. +This branch adds Feishu/workflow package tests and go vet to the workflow. +Remote GitHub Actions status should be checked on the PR page. +``` + +Known separate issue: + +```text +On this Windows workstation, go run ./internal/i18n/cmd/check still reports +internal\i18n\locales\en-US.json formatting. That fix is intentionally kept in +the separate i18n branch/PR and is not mixed into this Feishu change. +``` + ## Review and Comment Attribution Boundary Formal reviews and PR-associated Issue journals are consumed only by the diff --git a/reports/FEISHU_SMOKE_20260627.md b/reports/FEISHU_SMOKE_20260627.md index 60aad12..0427e02 100644 --- a/reports/FEISHU_SMOKE_20260627.md +++ b/reports/FEISHU_SMOKE_20260627.md @@ -6,11 +6,12 @@ Date: 2026-06-27 ```text branch: feat/feishu-export-clean -base commit: d7812df1af49519f9eb84def218bd3d5a9fdf02f +base: origin/master +head: 5a2e054 docs(feishu): keep validation evidence text-only ``` -This smoke run included uncommitted data-correctness fixes that are documented -below and will receive a new commit after final validation. +The data-correctness, PR review-audit, diagnostics, and text-only evidence +changes are committed in this branch. ## Environment @@ -213,18 +214,28 @@ No maintainer-role guess when member lookup is unavailable. | Check | Result | | --- | --- | -| `go test ./shortcuts/feishu` | pass | -| `go test ./shortcuts/workflow` | pass | -| `go test ./shortcuts` | pass | -| `go test ./...` | pass | -| `go build .` | pass | -| `go vet ./...` | pass | +| `go test ./shortcuts/feishu` | pass on 2026-06-27 | +| `go test ./shortcuts/workflow` | pass on 2026-06-27 | +| `go test ./shortcuts` | pass on 2026-06-27 | +| `go test ./...` | pass on 2026-06-27 | +| `go build .` | pass on 2026-06-27 | +| `go vet ./...` | pass on 2026-06-27 | | `go run ./internal/i18n/cmd/check` | blocked by existing Windows locale line-ending issue | | `go run ./internal/i18n/cmd/check --scan-code` | blocked by the same formatting check | The i18n line-ending and missing-key fix remains in its independent branch/PR and is intentionally not duplicated into this Feishu change. +## CI Status + +`.github/workflows/test.yml` already runs i18n validation on `origin/master`. +This branch adds Feishu/workflow package tests and `go vet` to that workflow. + +The local machine does not have GitHub CLI installed, and an unauthenticated +GitHub API query was rate-limited, so the remote GitHub Actions result was not +confirmed from this workstation. The PR page should be used as the source of +truth for remote CI status. + ## Screenshot Status Screenshot files are intentionally excluded from the repository. The project